Project

General

Profile

Bug #10819

ctfconvert should handle empty dies

Added by John Levon 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2019-04-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

http://smartos.org/bugview/OS-6488

This is the second half of OS-6428. In that ticket we came across a library, libcrypto.so, that contains both valid DWARF entries as well as objects which were not compiled with DWARF enabled. The current result of the conversion process is that the entire file is skipped even though most of it can be converted.

Robert's idea is to pass down the -i flag handling to determine whether we should abort or skip.

History

#1

Updated by Electric Monk 6 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 3eca610387779e26c8c63e26d2ba418b0cd1bf5a

commit  3eca610387779e26c8c63e26d2ba418b0cd1bf5a
Author: John Levon <john.levon@joyent.com>
Date:   2019-05-03T09:15:58.000Z

    10816 ctf_dwarf_convert_type() relies on un-initialized id
    10817 ctfconvert -i option is mis-handled
    10818 Improve ctfconvert error messages
    10819 ctfconvert should handle empty dies
    10820 ctfconvert -i never converts
    10821 bad free in ctf_dwarf_init_die
    10815 shouldn't build gcore.c as part of kmdb
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF