Project

General

Profile

Bug #10826

ctfdump -c goes off the rails with a missing parent

Added by John Levon 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2019-04-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

http://smartos.org/bugview/OS-7689

I noticed that some kernel module's ctfdump -c output was awry:

$ ctfdump -c ./platform/i86xpv/kernel/drv/amd64/balloon | more
/* Types */

typedef 0��p���0��0��<;

typedef struct cpu_ht cpu_ht_t;
...

instead of:

$ ctfdump -c -p ./kernel/amd64/genunix ./platform/i86xpv/kernel/drv/amd64/balloon | more
/* Types */

typedef void (*callback_func_t)(struct as *, void *, uint_t);

typedef struct cpu_ht cpu_ht_t;
...

I had tested the parent case, but clearly something broke at some point.

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 6ef284f1d464c08bc420048a0b211080cb9fe009

commit  6ef284f1d464c08bc420048a0b211080cb9fe009
Author: John Levon <john.levon@joyent.com>
Date:   2019-05-03T09:15:58.000Z

    10823 should ignore DW_TAG_subprogram with DW_AT_declaration tags
    10824 GCC7-derived CTF can double qualifiers on arrays
    10825 ctfdump -c drops last type
    10826 ctfdump -c goes off the rails with a missing parent
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF