Project

General

Profile

Bug #10846

webrev -c compares against working dir, not revision

Added by John Levon over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2019-04-23
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

webrev -c is supposed to produce a webrev corresponding to that git revision. However, in build_old_new_git(),
we just copy the working directory's file as the 'new' file. We need to use cat-file to get that revision's version
of the file instead (not sure if we need to be careful about deleted/renamed files and whatnot).

Also available in: Atom PDF