Project

General

Profile

Actions

Bug #10869

closed

fcp: comparison between pointer and integer

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Debug build errors with NULL pointer:

    In file included from ../../common/sys/model.h:35:0,
                     from ../../common/sys/resource.h:221,
                     from ../../common/sys/user.h:73,
                     from ../../common/sys/proc.h:36,
                     from ../../common/sys/systm.h:40,
                     from ../../common/sys/scsi/scsi_types.h:56,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/fibre-channel/ulp/fcp.c:27:
    ../../common/io/fibre-channel/ulp/fcp.c: In function 'fcp_queue_pkt':
    ../../common/io/fibre-channel/ulp/fcp.c:14584:50: error: comparison between pointer and integer [-Werror]
      ASSERT((cmd->cmd_pkt->pkt_flags & FLAG_NOQUEUE) == NULL);
                                                      ^
    ../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
     #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                                 ^~
    cc1: all warnings being treated as errors

Actions

Also available in: Atom PDF