Project

General

Profile

Bug #10875

arn: comparison between pointer and integer

Added by Toomas Soome 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Debug build errors with NULL pointer:

    In file included from ../../common/sys/model.h:35:0,
                     from ../../common/sys/resource.h:221,
                     from ../../common/sys/vnode.h:51,
                     from ../../common/vm/seg.h:43,
                     from ../../common/vm/as.h:47,
                     from ../../common/sys/devops.h:37,
                     from ../../common/sys/sunddi.h:39,
                     from ../../common/sys/mac.h:33,
                     from ../../common/sys/net80211.h:45,
                     from ../../common/io/arn/arn_core.h:31,
                     from ../../common/io/arn/arn_recv.c:24:
    ../../common/io/arn/arn_recv.c: In function 'arn_rx_handler':
    ../../common/io/arn/arn_recv.c:450:41: error: comparison between pointer and integer [-Werror]
       ASSERT(bf->bf_dma.cookie.dmac_address != NULL);
                                             ^
    ../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
     #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                                 ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 411e5762bff38b7fee2b31a987c104503ddc9c9c

commit  411e5762bff38b7fee2b31a987c104503ddc9c9c
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-16T19:26:14.000Z

    10875 arn: comparison between pointer and integer
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF