Project

General

Profile

Bug #10879

i86pc/i86xpv: assignment makes integer from pointer without a cast

Added by Toomas Soome 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2019-04-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Debug build errors with NULL pointer:

    ../../i86pc/os/mp_startup.c: In function 'mp_cpu_unconfigure_common':
    ../../i86pc/os/mp_startup.c:552:18: error: assignment makes integer from pointer
     without a cast [-Werror=int-conversion]
       ttc->ttc_first = NULL;
                      ^
    ../../i86pc/os/trap.c: In function 'dump_ttrace':
    ../../i86pc/os/trap.c:2091:22: error: comparison between pointer and integer [-W
    error]
       if (ttc->ttc_first == NULL)
                          ^~
    ../../i86pc/os/trap.c:2107:16: error: comparison between pointer and integer [-W
    error]
        if (current == NULL)
                    ^~
    cc1: all warnings being treated as errors

Those sources are built for both i86pc and i86xpv.

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit 8f22c1dff63d6147c87d6bff65bcd3970ad4d368

commit  8f22c1dff63d6147c87d6bff65bcd3970ad4d368
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-15T20:16:55.000Z

    10879 i86pc/i86xpv: assignment makes integer from pointer without a cast
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF