Project

General

Profile

Actions
Copy link

Bug #10881

closed

more C99 math macros should be compiler builtins

Added by Rich Lowe over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
lib - userland libraries
Start date:
2019-04-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

For compilers other than studio, we define our own, sub-par implementations of isinf, isnan, isnormal, signbit, etc.
We should use the builtins under GCC to avoid warnings from the compiler (for instance, signbit() breaks strict aliasing rules).

Related issues

Related to illumos gate - Bug #11175: libm should use signbit() correctlyClosedRich Lowe

Actions
Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit f26364c965228a50041eda19745fc8573312c654

commit  f26364c965228a50041eda19745fc8573312c654
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2019-05-09T19:37:40.000Z

    10881 more C99 math macros should be compiler builtins
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link
 #2

Updated by Andy Fiddaman over 4 years ago

  • Related to Bug #11175: libm should use signbit() correctly added
Actions
Copy link
 #3

Updated by Electric Monk over 4 years ago

git commit 14d22e96203fbce3b2e8b2a78b4a769d2d112cac

commit  14d22e96203fbce3b2e8b2a78b4a769d2d112cac
Author: Rich Lowe <richlowe@richlowe.net>
Date:   2019-06-03T00:18:15.000Z

    10881 more C99 math macros should be compiler builtins (fix signbit compatibility)
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF