Feature #10896
closed
Want support for AMD Zen CPC events
100%
Description
We should update the AMD CPU Performance counters to cover the EPYC systems. I tested this by looking at the generated manual pages, going through and running this on AMD EPYC systems and verifying that I could run 6 different classes of events. I also went back and just sanity tested an Intel system and made sure that the generated Intel CPC files hadn't changed.
Note, the data files are something that I constructed myself. We should consider going back and doing this for older platforms as well. One side effect of this change was that there was code that said if an unknown AMD platform shows up, just assume that the generic counters are valid. However, that wasn't true across most of the generations I looked at, so that behavior was removed. However, it should now be easier to add support for a new generation of CPU performance counters or go back and add support for old ones.
Related issues
Updated by Electric Monk about 4 years ago
- Status changed from New to Closed
git commit d0e58ef5d66890a3cd67c9c6eb8c823f9865a70f
commit d0e58ef5d66890a3cd67c9c6eb8c823f9865a70f
Author: Robert Mustacchi <rm@joyent.com>
Date: 2019-05-09T03:17:34.000Z
10896 Want support for AMD Zen CPC events
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Dan McDonald <danmcd@joyent.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Updated by Robert Mustacchi about 3 years ago
- Related to Feature #12452: Want support for AMD Zen 2 CPC Events added
Updated by Robert Mustacchi about 2 months ago
- Related to Bug #15539: opteron_pcbe broken on pre-Zen after 10896 added