Project

General

Profile

Bug #10900

Fix estimated scrub completion time

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2019-05-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

ZoL update:

Author: Tom Caputi <tcaputi@datto.com>
Date:   Wed May 1 20:34:24 2019 -0400

    Fix estimated scrub completion time

        Currently, it is possible for the 'zpool scrub' command to
        progress slightly beyond 100% due to concurrent changes
        happening on the live pool. This behavior is expected, but
        the userspace code for 'zpool status' would subtract the
        expected amount of data from the amount of data already
        scrubbed, resulting in a negative integer being casted to a
        large positive one. This number was then used to calculate
        the estimated completion time, resulting in wildly wrong
        results. This code changes the behavior so that 'zpool status'
        does not attempt to report an estimate during this period.

        Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
        Reviewed-by: Igor Kozhukhov <igor@dilos.org>
        Reviewed-by: George Melikov <mail@gmelikov.ru>
        Signed-off-by: Tom Caputi <tcaputi@datto.com>
        Closes #8611
        Closes #8687

After this fix, the zpool status output does display more reasonable output.


Related issues

Related to illumos gate - Feature #10405: Implement ZFS sorted scansClosed2019-03-19

Actions
Related to illumos gate - Bug #10566: Multiple DVA Scrubbing FixIn Progress2019-03-19

Actions

History

#1

Updated by Toomas Soome 7 months ago

#2

Updated by Toomas Soome 7 months ago

  • Related to Bug #10566: Multiple DVA Scrubbing Fix added
#3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3db6627c6730f7ec4426ac0be0e9338235aed2d8

commit  3db6627c6730f7ec4426ac0be0e9338235aed2d8
Author: Tom Caputi <tcaputi@datto.com>
Date:   2019-05-13T20:49:36.000Z

    10900 Fix estimated scrub completion time
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF