Project

General

Profile

Actions

Bug #10929

closed

loader: efi_zfs_is_preferred: was && intended here instead of ||

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-05-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

smatch error.

We want to get out if this device is not disk.

Disks are: (DevicePathType(node) MEDIA_DEVICE_PATH) && (DevicePathSubType(node) MEDIA_FILEPATH_DP || DevicePathSubType(node) MEDIA_HARDDRIVE_DP)

Therefore !Disk is: !((DevicePathType(node) MEDIA_DEVICE_PATH) && (DevicePathSubType(node) MEDIA_FILEPATH_DP || DevicePathSubType(node) MEDIA_HARDDRIVE_DP))
Which is: (!(DevicePathType(node) MEDIA_DEVICE_PATH) || (!(DevicePathSubType(node) MEDIA_FILEPATH_DP && ! DevicePathSubType(node) == MEDIA_HARDDRIVE_DP))
Which is: (DevicePathType(node) != MEDIA_DEVICE_PATH) || (DevicePathSubType(node) != MEDIA_FILEPATH_DP && DevicePathSubType(node) != MEDIA_HARDDRIVE_DP)

the () are probably a bit off.

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 76eff6ad4aa646f8d8aa38f7dda4824170170280

commit  76eff6ad4aa646f8d8aa38f7dda4824170170280
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-14T03:01:27.000Z

    10929 loader: efi_zfs_is_preferred: was && intended here instead of ||
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF