Project

General

Profile

Actions
Copy link

Bug #10933

closed

loader: Make lsdev -v output line up in neat columns

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2019-05-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

FreeBSD updates:

r344239

    Use a couple local variables to avoid repetitive long expressions that
    cause line-wrapping.

r344240

    Make lsdev -v output line up in neat columns by using a fixed width for
    the size field and a tab between the partition type and the size.

    Changes this

      disk devices:
            disk0 (MMC)
            disk0s1: DOS/Windows            49MB
            disk0s2: FreeBSD                14GB
            disk0s2a: FreeBSD UFS         14GB
            disk0s2b: Unknown             2048KB
            disk0s2d: FreeBSD UFS         2040KB

    to this

      disk devices:
            disk0 (MMC)
            disk0s1: DOS/Windows      49MB
            disk0s2: FreeBSD          14GB
            disk0s2a: FreeBSD UFS     14GB
            disk0s2b: Unknown       2048KB
            disk0s2d: FreeBSD UFS   2040KB

r344241

    Garbage collection no-longer-used constant.

r347389
    loader: ptable_print() needs two tabs sometimes

    Since the partition/slice names do vary in length, check the length
    of the fixed part of the line against 3 * 8, if the lenth is less than
    3 tab stops, print out extra tab.

    use snprintf() instead of sprintf.

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 18d216a40f7635825d65521fbec434de192b5014

commit  18d216a40f7635825d65521fbec434de192b5014
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-15T07:55:24.000Z

    10933 loader: Make lsdev -v output line up in neat columns
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF