Project

General

Profile

Bug #10934

loader: improve some debugging experience

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-05-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

FreeBSD updates:
r345066

    Some of these files using <FOO>_DEBUG defined a DEBUG() macro to serve as a
    debug-printf. -DDEBUG is useful to enable some debugging output across
    multiple ELF/common parts, so switch the DEBUG-as-printf macros over to
    something more like DPRINTF that is more commonly used for this kind of
    thing and less likely to conflict.

    userboot/elf64_freebsd debugging also assumed %llx for uint64; use PRIx64
    instead.

347393
    loader: use DPRINTF in biosdisk.c and define safe DPRINTF

    r345066 did miss biosdisk.c.

    Also define DPRINTF as ((void)0) for case we do not want debug printouts.

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 7efc4ab5dcfd200d52afe798e576fd15b3ffad2d

commit  7efc4ab5dcfd200d52afe798e576fd15b3ffad2d
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-15T07:54:00.000Z

    10934 loader: improve some debugging experience
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF