SMB2 kstats don't correctly count compound requests
Running smbstat -r, there are time when % inexplicably doesn't add up to 100.
Steps to Reproduce:
smbstat -rz 10
% always add up to 100.
Updated by Gordon Ross 5 days ago
The main problem is 'overcount' (exclusive to SMB2+). It happens because the 'total number of requests' is only increased when a message is received, but the 'individual number of requests' is incremented for each request in a compound. This means the sum of individual request counts can exceed the total number of requests counted. Move the increments so these reconcile.
Updated by Electric Monk 4 days ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit ac2bf314e776a9dcb4faf4d3f88408ed942f0fae Author: Matt Barden <firstname.lastname@example.org> Date: 2019-05-19T23:21:45.000Z 10971 SMB2 kstats don't correctly count compound requests Reviewed by: Gordon Ross <email@example.com> Reviewed by: Evan Layton <firstname.lastname@example.org> Approved by: Joshua M. Clulow <email@example.com>