Project

General

Profile

Bug #1100

cpustat usage message is incorrect

Added by Rich Lowe over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
cmd - userland programs
Start date:
2011-06-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

cpustat's usage message says:
Usage:
cpustat [-c events] [-p period] [-nstD] [-T d|u] [interval [count]]

At least one instance of -c is mandatory, it shouldn't be in brackets

History

#1

Updated by Thomas Gouverneur over 8 years ago

  • Assignee set to Thomas Gouverneur
  • % Done changed from 0 to 50

Webrev done, will be sent to the developers mailling for code review.

http://wildcat.espix.org/cr/illumos-1100-webrev/

#2

Updated by Thomas Gouverneur over 8 years ago

  • % Done changed from 50 to 100
#3

Updated by Thomas Gouverneur over 8 years ago

  • Status changed from New to Feedback
#4

Updated by Ryan Zezeski over 4 years ago

  • Assignee changed from Thomas Gouverneur to Ryan Zezeski

http://zinascii.com/pub/illumos/webrevs/1100/

There was an existing webrev for this but the review seems to have
slipped through the cracks. I made a new patch that is pretty much the
same but I also changed cpustat usage to list its arguments in the same
order as the manual.

$ ./cpustat -h
Usage:
        cpustat -c spec [-c spec]... [-p period] [-T u|d]
                [-sntD] [interval [count]]

        -c spec   specify processor events to be monitored
...

$ man cpustat
...
SYNOPSIS
     cpustat -c eventspec [-c eventspec]... [-p period] [-T u | d ]
          [-sntD] [interval [count]]
...
#5

Updated by Electric Monk over 4 years ago

  • Status changed from Feedback to Closed

git commit bd181d5a0c2b96669dcb4aa44619e0b7dbbedab9

commit  bd181d5a0c2b96669dcb4aa44619e0b7dbbedab9
Author: Ryan Zezeski <ryan@zinascii.com>
Date:   2015-02-03T20:00:10.000Z

    1100 cpustat usage message is incorrect
    Reviewed by: David Höppner <0xffea@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF