Project

General

Profile

Bug #11045

libstand: smatch errors in dosfs and zfs reader

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-05-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

smatch errors:

    /code/illumos-gate/usr/src/boot/lib/libstand/dosfs.c:694 cp_xdnm() warn: if statement not indented

    /code/illumos-gate/usr/src/boot/lib/libstand/dosfs.c:155 dos_read_fatblk() warn: should '(fs->spf) << 9' be a 64 bit type?

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1711 fzap_list() warn: should '(i + 1) << zl.l_bs' be a 64 bit type?

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1874 fzap_rlookup() warn: should '(i + 1) << zl.l_bs' be a 64 bit type?

First issue is simple tab issue, second ones we cast to 64-bit type.

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 130d76529cb137edd96e5cb68f129e459d784703

commit  130d76529cb137edd96e5cb68f129e459d784703
Author: Toomas Soome <tsoome@me.com>
Date:   2019-05-21T13:51:34.000Z

    11045 libstand: smatch errors in dosfs and zfs reader
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF