Project

General

Profile

Bug #11074

loader: mod_loadkld() error: we previously assumed 'last_file' could be null

Added by Toomas Soome 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-05-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

smatch error. In edge case, it is possible we will dereference NULL pointer.

The problem there is about recovery when we fail to read the file into load area; to fix, I figured it is better to record the last load address and implement function to remove the file from the list.

Testing done: build/install/boot, the loading and boot is behaving as expected.

History

#1

Updated by Electric Monk 4 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit a8412dc108558a7a3635b7ab4f3b1b743bdff9e8

commit  a8412dc108558a7a3635b7ab4f3b1b743bdff9e8
Author: Toomas Soome <tsoome@me.com>
Date:   2019-06-18T17:40:59.000Z

    11074 loader: mod_loadkld() error: we previously assumed 'last_file' could be null
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF