Project

General

Profile

Bug #11076

ZFS test mmp_on_zdb should clear disk labels on exit

Added by Kody Kantor 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2019-05-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The mmp_on_zdb test fails to properly clean up disk labels when it exits. This can cause later tests to fail due to ZFS' belief that different pools with the same name but different pool GUIDs are present on the system.

History

#1

Updated by Kody Kantor 4 months ago

To test this I ran the MMP tests from the zfs test suite:

$ ./zfstest -c ../kkantor.run
Test: /opt/zfs-tests/tests/functional/mmp/setup (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_on_thread (run as root) [00:17] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_on_uberblocks (run as root) [00:21] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_on_off (run as root) [00:25] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_interval (run as root) [00:02] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_active_import (run as root) [05:54] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_inactive_import (run as root) [01:29] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_exported_import (run as root) [01:53] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_write_uberblocks (run as root) [00:13] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_reset_interval (run as root) [00:13] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/multihost_history (run as root) [00:12] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/mmp_on_zdb (run as root) [00:35] [PASS]
Test: /opt/zfs-tests/tests/functional/mmp/cleanup (run as root) [00:06] [PASS]

Results Summary
PASS 13

Running Time: 00:11:48
Percent passed: 100.0%
Log directory: /var/tmp/test_results/20190530T194244

#2

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 63c8e5c0c7ad69bb8a1fe9cc14cd05e4ff44e8ea

commit  63c8e5c0c7ad69bb8a1fe9cc14cd05e4ff44e8ea
Author: Kody Kantor <kody@kkantor.com>
Date:   2019-05-31T12:57:58.000Z

    11076 ZFS test mmp_on_zdb should clear disk labels on exit
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Toomas Soome <toomas@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: John Kennedy <john.kennedy@delphix.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF