illumos gate

Many commits from illumos-nexenta, plus more from testing, comprise what will be this. Some of the commits have been spun off into their own bugs (e.g. #2988).

My webrevs directory has a bunch of versions and incremental webrevs: http://kebe.com/~danmcd/webrevs/nfs-zone/ (Note: in the future this will move into the "old/" subdirectory, i.e. http://kebe.com/~danmcd/webrevs/old/nfs-zone/ ).

Included here from illumos-nexenta are (at least initially):

NEX-15279 support NFS server in zone
NEX-15520 online NFS shares cause zoneadm halt to hang in nfs_export_zone_fini
NEX-16502 libshare needs to support SMB in a zone
NEX-16452 NFS server in a zone state database needs to be per zone
NEX-16712 NFS dtrace providers do not support per-share filtering
NEX-16812 Timing window where dtrace probe could try to access share info after unshared
NEX-17125 NFS: nbmand lock entered but not exited on error path
NEX-18312 Max number of nfsd threads is set too high, thus affecting NFS performance
(Reduces nfsd thread count from 1024 down to 256.)
NEX-18369 SMB & NFS dtrace providers do not support per-zone filtering
NEX-18716 The NFS grace period is too long causing long failover times.
(Changes NFS lock manager grace period from 90secs to 30secs)
NEX-15740 NFS deadlock in rfs4_compound with hundreds of threads waiting for lock owned by rfs4_op_rename
NEX-19178 Changing the NFS export path makes the SMB share offline
NEX-19996 exi_id_get_next() calls should be WRITER locked
NEX-20014 NFS v4 state lock mutex exited before entered (on error path)
NEX-20260 NFS hung in transitional state when RSF marks it maintenance
NEX-20423 NFSv4 state database entry locking is not always used around reference count.
NEX-18681 NFS does not quiesce client state to the pool
(Changes NFS lock manager grace period AGAIN, from 30secs to 60secs)

Additional fixes post-project-commencement include:

- Try to remove assumption that zone's root vnode is marked VROOT
- curzone reality check and teardown changes to use the RIGHT zone
- nfs_export_zone_init() can't assume called in zone-context.
- NFSv4 may zone-cleanup before exports do.
- Fix nlm_unexport
- Fix NFS design problems re. multiple zone keys
- Make NFS server zone-specific data all have the same lifetime
- Fix rfs4_clean_state_exi
- Fix exi_cache_reclaim
- Fix mistakes in zone keys work
- More fixes re. exi_zoneid and exi_tree
- Be far more judicious in the use of curzone-using macros.
- Untrip aggressive assert AND use EXI_TO_ZONEROOTVP
- Send zone's rootvp to untraverse()
- Plug memory leaks:
- Plug sharefs zone-shutdown leaks
- Go ahead and destroy the NFSv4 database tables
- Do rfs4_ss_fini() BEFORE rfs4_servinst_destroy_all().
- dss_paths[] entries need cleanup too
- NFS Auth per-zone needs better cleanup
- Two NLM fixes: use zone_kcred() and plug cl_auth leaks
- Zone ID only matches once, don't loop after a match
- Caution with use after exi_rele()

Testing notes 1/N:

Since this project's inception: smoke & mild-stress testing including:

- Doing simple operations via MacOS (NFSv3) client using automount paths.
- Doing simple operations via illumos (NFSv4) client using automount paths.
- Building illumos-gate where illumos-gate is using the same aforementioed NFSv4 client.

A few constant-changes arrived with this wad of fixes from Nexenta. The comment listing the Nexenta bug list should have indicators about them now.

Note that this issue implements the majority of IPD 11 .

pynfs test-suite with

./testserver.py  $SERVER_IP:/data --maketree --rundep all

Shows the same results for pre-change-global-zone and nfs-in-zone cases:

Command line asked for 587 of 672 tests
Of those: 95 Skipped, 47 Failed, 4 Warned, 441 Passed

git commit 0dfe541e13279d277d838d6a27e55188b9486cb1

commit  0dfe541e13279d277d838d6a27e55188b9486cb1
Author: Evan Layton <evan.layton@nexenta.com>
Date:   2020-02-07T17:52:15.000Z

    11083 support NFS server in zone
    Portions contributed by: Dan Kruchinin <dan.kruchinin@nexenta.com>
    Portions contributed by: Stepan Zastupov <stepan.zastupov@gmail.com>
    Portions contributed by: Joyce McIntosh <joyce.mcintosh@nexenta.com>
    Portions contributed by: Mike Zeller <mike@mikezeller.net>
    Portions contributed by: Dan McDonald <danmcd@joyent.com>
    Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
    Portions contributed by: Vitaliy Gusev <gusev.vitaliy@gmail.com>
    Reviewed by: Rick McNeal <rick.mcneal@nexenta.com>
    Reviewed by: Rob Gittins <rob.gittins@nexenta.com>
    Reviewed by: Sanjay Nadkarni <sanjay.nadkarni@nexenta.com>
    Reviewed by: Jason King <jbk@joyent.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Garrett D'Amore <garrett@damore.org>