clean up file-backed l2arc support
The multi-modifier protection commit (379ca9cf2 in ZoL, e0f1c0afa in illumos) changed ZFS to allow file-backed l2arc vdevs. File-backed l2arc was previously not allowed. I got confirmation that this change was intentional. At least one test (cache_010_neg) checked that file-backed l2arc vdevs couldn't be created, so this test now fails. In addition to removing this check from the tests we can remove the userspace code that checks for ENOTBLK errors from in-kernel ZFS.
Updated by Kody Kantor 4 months ago
We switched the zfs-test cache_010_neg from asserting that file-backed l2arc can't be created to asserting that file-backed l2arc can be created. This ensures that the cache family of zfs-tests now passes:
$ ./bin/zfstest -c ./kkantor.run Test: /opt/zfs-tests/tests/functional/cache/setup (run as root) [00:19] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_001_pos (run as root) [02:56] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_002_pos (run as root) [00:33] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_003_pos (run as root) [00:27] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_004_neg (run as root) [00:09] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_005_neg (run as root) [00:09] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_006_pos (run as root) [00:49] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_007_neg (run as root) [00:01] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_008_neg (run as root) [00:37] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_009_pos (run as root) [00:28] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_010_neg (run as root) [00:03] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cache_011_pos (run as root) [00:19] [PASS] Test: /opt/zfs-tests/tests/functional/cache/cleanup (run as root) [00:00] [PASS] Results Summary PASS 13 Running Time: 00:06:56 Percent passed: 100.0% Log directory: /var/tmp/test_results/20190621T190145
There aren't any new failures from the zfs-test suite either.
Updated by Electric Monk 4 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit c1d5c2a48971d1705730e1ade6a1bc4d56587416 Author: Kody Kantor <email@example.com> Date: 2019-06-21T18:59:47.000Z 11084 clean up file-backed l2arc support Reviewed by: Igor Kozhukhov <firstname.lastname@example.org> Reviewed by: Toomas Soome <email@example.com> Reviewed by: Jerry Jelinek <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>