Project

General

Profile

Actions

Bug #11125

closed

libpicltree: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    ../picltree.c: In function 'picl_hdl_error':
    ../picltree.c:594:16: error: comparison between pointer and integer [-Werror]
          (hash_val == NULL))
                    ^~
    ../picltree.c: In function 'ptree_hdl_error':
    ../picltree.c:613:16: error: comparison between pointer and integer [-Werror]
          (hash_val == NULL))
                    ^~
    In file included from ../picltree.c:131:0:
    ../picltree.c: In function 'unpiclize_prop':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1003:7: note: in expansion of macro 'IS_PICLIZED'
      if (!IS_PICLIZED(propp))
           ^~~~~~~~~~~
    ../picltree.c: In function 'unpiclize_node':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1025:7: note: in expansion of macro 'IS_PICLIZED'
      if (!IS_PICLIZED(nodep))
           ^~~~~~~~~~~
    ../picltree.c: In function 'ptree_add_prop':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1498:7: note: in expansion of macro 'IS_PICLIZED'
       if (IS_PICLIZED(nodep) && !IS_PICLIZED(refobj)) {
           ^~~~~~~~~~~
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1498:30: note: in expansion of macro 'IS_PICLIZED'
       if (IS_PICLIZED(nodep) && !IS_PICLIZED(refobj)) {
                                  ^~~~~~~~~~~
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1508:6: note: in expansion of macro 'IS_PICLIZED'
      if (IS_PICLIZED(nodep))
          ^~~~~~~~~~~
    ../picltree.c: In function 'ptree_add_row_to_table':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1666:7: note: in expansion of macro 'IS_PICLIZED'
       if (IS_PICLIZED(pobj) || (pobj->prop_table != NULL) ||
           ^~~~~~~~~~~
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1684:6: note: in expansion of macro 'IS_PICLIZED'
      if (IS_PICLIZED(tbl_obj))
          ^~~~~~~~~~~
    ../picltree.c: In function 'ptree_destroy_node':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:1938:6: note: in expansion of macro 'IS_PICLIZED'
      if (IS_PICLIZED(nodep)) {
          ^~~~~~~~~~~
    ../picltree.c: In function 'ptree_add_node':
    ../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
     #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                            ^
    ../picltree.c:2062:6: note: in expansion of macro 'IS_PICLIZED'
      if (IS_PICLIZED(pnodep))
          ^~~~~~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ee613b78cf1b6f1080e74ce30191198ffa9bcb11

commit  ee613b78cf1b6f1080e74ce30191198ffa9bcb11
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-03T05:46:36.000Z

    11125 libpicltree: NULL pointer errors
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF