Project

General

Profile

Bug #11141

libdtrace: NULL pointer errors

Added by Toomas Soome 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    ../common/dt_handle.c: In function 'dt_handle_liberr':
    ../common/dt_handle.c:250:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      err.dteda_addr = NULL;
                     ^

    ../common/dt_map.c: In function 'dt_aggid_add':
    ../common/dt_map.c:387:35: error: comparison between pointer and integer [-Werror]
           agg->dtagd_rec[0].dtrd_uarg != NULL) {
                                       ^~

    ../common/dt_module.c: In function 'dt_module_unload':
    ../common/dt_module.c:909:18: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      dmp->dm_text_va = NULL;
                      ^
    ../common/dt_module.c:911:18: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      dmp->dm_data_va = NULL;
                      ^
    ../common/dt_module.c:913:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      dmp->dm_bss_va = NULL;
                     ^

    ../common/dt_consume.c: In function 'dt_print_stack':
    ../common/dt_consume.c:1280:10: error: comparison between pointer and integer [-Werror]
       if (pc == NULL)
              ^~
    ../common/dt_consume.c: In function 'dt_print_ustack':
    ../common/dt_consume.c:1368:33: error: comparison between pointer and integer [-Werror]
      for (i = 0; i < depth && pc[i] != NULL; i++) {
                                     ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 4 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit d60ff33691519a9505afc8818735139f4dfd0c31

commit  d60ff33691519a9505afc8818735139f4dfd0c31
Author: Toomas Soome <tsoome@me.com>
Date:   2019-06-24T19:57:27.000Z

    11141 libdtrace: NULL pointer errors
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF