Project

General

Profile

Actions

Bug #11148

closed

libbsm: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    ../common/audit_allocate.c: In function 'audit_allocate_record':
    ../common/audit_allocate.c:123:3: error: comparison between pointer and integer [-Werror]
       == NULL)
       ^~
    ../common/getdaent.c: In function 'getdadmline':
    ../common/getdaent.c:136:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       *cp = NULL;
           ^
    ../common/getdaent.c:151:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *ccp = NULL;
              ^
    ../common/getdaent.c:159:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
        *ccp = NULL;
             ^

    ../common/getdment.c: In function 'getdmapfield':
    ../common/getdment.c:683:11: error: comparison between pointer and integer [-Werror]
      if (*ptr == NULL)
               ^~
    ../common/getdment.c: In function 'getdmapdfield':
    ../common/getdment.c:703:11: error: comparison between pointer and integer [-Werror]
      if (*ptr == NULL)
               ^~

    ../common/devalloc.c: In function 'da_remove_list':
    ../common/devalloc.c:1915:11: error: comparison between pointer and integer [-Werror]
      if (type != NULL)
               ^~
    ../common/devalloc.c:1952:12: error: comparison between pointer and integer [-Werror]
      if ((type != NULL) && (link == NULL)) {
                ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit baf3abb99faf2cc8376a1f8ab38dfa1730c2ca13

commit  baf3abb99faf2cc8376a1f8ab38dfa1730c2ca13
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-03T07:36:13.000Z

    11148 libbsm: NULL pointer errors
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF