Project

General

Profile

Actions
Copy link

Bug #11154

closed

pkcs11_tpm: NULL pointer errors

Added by Toomas Soome almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    ../common/new_host.c: In function 'SC_SeedRandom':
    ../common/new_host.c:2320:33: error: comparison between pointer and integer [-Werror]
      if (pSeed == NULL || ulSeedLen == NULL)
                                     ^~

    ../common/tpm_specific.c: In function 'token_rsa_load_key':
    ../common/tpm_specific.c:2278:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      *phKey = NULL;
             ^
    ../common/tpm_specific.c:2309:14: error: comparison between pointer and integer [-Werror]
       if (*phKey != NULL) {
                  ^~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e2e372a44e0036831b4a1b5f80a7c680223275fa

commit  e2e372a44e0036831b4a1b5f80a7c680223275fa
Author: Toomas Soome <tsoome@me.com>
Date:   2019-06-25T20:27:32.000Z

    11154 pkcs11_tpm: NULL pointer errors
    Reviewed by: Jason Lippert <jason@glasspelican.ca>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF