Project

General

Profile

Actions
Copy link

Bug #11155

closed

brand: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../common/brand_util.c: In function 'brand_post_init':
    ../common/brand_util.c:369:12: error: comparison between pointer and integer [-Werror]
      while (*p != NULL)
                ^~
    ../common/brand_util.c:404:22: error: comparison between pointer and integer [-Werror]
         if (sed.sed_base == NULL) {
                          ^~
    ../common/brand_util.c:406:21: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
          ap->a_un.a_val = NULL;
                         ^
    ../common/brand_util.c:435:20: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         ap->a_un.a_val = NULL;
                        ^
    ../common/brand_util.c:439:24: error: comparison between pointer and integer [-Werror]
         if (sed.sed_lddata == NULL) {
                            ^~
    ../common/brand_util.c:441:21: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
          ap->a_un.a_val = NULL;
                         ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit b168296d3fe15e5a2f992bf6af96993c6756ff3a

commit  b168296d3fe15e5a2f992bf6af96993c6756ff3a
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-03T20:41:53.000Z

    11155 brand: NULL pointer errors
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF