Project

General

Profile

Actions

Bug #11166

closed

libnisdb: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    ldap_xdr.c: In function 'xdr_nis_name_abbrev':
    ldap_xdr.c:120:15: error: comparison between pointer and integer [-Werror]
       if ((buf[0] == NULL) || buf[strlen(buf) - 1] == '.') {
                   ^~

    nis_parse_ldap_util.c: In function 'free_table_mapping':
    nis_parse_ldap_util.c:293:27: error: comparison between pointer and integer [-Werror]
      if (mapping->commentChar != NULL)
                               ^~
    nis_parse_ldap_util.c:294:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       mapping->commentChar = NULL;
                            ^

    nis_parse_ldap_map.c: In function 'add_mapping_attribute':
    nis_parse_ldap_map.c:214:29: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
          t_mapping->commentChar = NULL;
                                 ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a345176509a14142f643dda699929edbc3c0bb55

commit  a345176509a14142f643dda699929edbc3c0bb55
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-01T18:43:09.000Z

    11166 libnisdb: NULL pointer errors
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF