Project

General

Profile

Bug #11167

libsldap: NULL pointer errors

Added by Toomas Soome 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../common/ns_confmgr.c:44:0:
    ../common/ns_confmgr.c: In function 'read_file':
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:126:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_FILE, strdup(errstr), NULL);
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:151:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:160:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:169:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:189:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:209:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:221:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_parse_status {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:229:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_confmgr.c: In function 'set_attr':
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_ldap_return_code {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_confmgr.c:268:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *errorp, NS_LDAP_CONFIG, strdup(errmsg), NULL);
       ^~~~~~~
    ../common/ns_confmgr.c: In function '__ns_ldap_download':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_confmgr.c:1015:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *errorp, NS_CONFIG_NOTLOADED, strdup(errstr),
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_confmgr.c:1049:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *errorp, NS_CONFIG_NOTLOADED, strdup(errstr),
       ^~~~~~~

    In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/stdio_iso.h:53:0,
                     from /code/illumos-gate/proto/root_i386/usr/include/stdio.h:82,
                     from ../common/ns_config.c:31:
    /code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: incompatible types when initializing type 'enum <anonymous>' using type 'void *'
     #define NULL ((void *)0)
                  ^
    ../common/ns_config.c:534:35: note: in expansion of macro 'NULL'
       CLIENTCONFIG, NS_UNKNOWN, TRUE, NULL,
                                       ^~~~
    ../common/ns_config.c: In function '__s_api_crosscheck':
    ../common/ns_config.c:1173:47: error: comparison between pointer and integer [-Werror]
           ptr->paramList[NS_LDAP_AUTH_P].ns_pi[j] != NULL; j++) {
                                                   ^~
    In file included from ../common/ns_config.c:55:0:
    ../common/ns_config.c: In function 'set_default_value':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1382:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_config.c: In function '__ns_ldap_setParamValue':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1655:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1701:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1723:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1752:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1860:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:1972:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2214:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_ERR, *error,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2240:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2286:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_ERR, *error,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2312:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2331:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2389:7: note: in expansion of macro 'MKERROR'
           MKERROR(LOG_ERR, *error,
           ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2404:7: note: in expansion of macro 'MKERROR'
           MKERROR(LOG_ERR, *error,
           ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2499:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_ERR, *error,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2577:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_ERR, *error,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2591:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_ERR, *error,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2622:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2640:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *error, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_config.c: In function '__ns_ldap_setParam':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2732:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_WARNING, *error, NS_CONFIG_SYNTAX, strdup(errstr),
       ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2757:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *error, NS_CONFIG_NOTLOADED,
        ^~~~~~~
    ../common/ns_config.c: In function '__ns_ldap_getParam':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2957:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *error, NS_CONFIG_NOTLOADED,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:2978:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *error, NS_CONFIG_NOTLOADED,
       ^~~~~~~
    ../common/ns_config.c: In function '__door_getconf':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:3320:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_WARNING, *error, NS_CONFIG_CACHEMGR,
       ^~~~~~~
    ../common/ns_config.c: In function 'SetDoorInfoToUnixCred':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:3391:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *errorp, NS_CONFIG_SYNTAX,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_config.c:3406:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_ERR, *errorp, NS_CONFIG_SYNTAX,
        ^~~~~~~
    In file included from ../common/ns_reads.c:39:0:
    ../common/ns_reads.c: In function 'get_mapped_filter':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:1364:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_WARNING, cookie->errorp,
         ^~~~~~~
    ../common/ns_reads.c: In function 'multi_result':
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2054:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, err,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2124:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, err,
        ^~~~~~~
    ../common/ns_reads.c: In function 'search_state_machine':
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2382:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, err,
        ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2919:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_INFO, *errorp,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2922:6: note: in expansion of macro 'MKERROR'
          MKERROR(LOG_WARNING, *errorp,
          ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2926:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL,
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: incompatible types when returning type 'void *' but 'ns_state_t {aka enum <anonymous>}' was expected
       return (retErr); \
              ^
    ../common/ns_reads.c:2950:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, err,
        ^~~~~~~
    ../common/ns_reads.c: In function 'check_shadow':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:3028:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_INFO, cookie->errorp, NS_LDAP_INTERNAL, err,
        ^~~~~~~
    ../common/ns_reads.c: In function '__ns_ldap_getAttr':
    ../common/ns_reads.c:4111:59: error: comparison between pointer and integer [-Werror]
       if (strcasecmp(entry->attr_pair[i]->attrname, attrname) == NULL)
                                                               ^~
    ../common/ns_reads.c: In function '__ns_ldap_getAttrStruct':
    ../common/ns_reads.c:4125:59: error: comparison between pointer and integer [-Werror]
       if (strcasecmp(entry->attr_pair[i]->attrname, attrname) == NULL)
                                                               ^~
    In file included from ../common/ns_reads.c:39:0:
    ../common/ns_reads.c: In function '__ns_ldap_uid2dn':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:4222:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, strdup(errstr),
       ^~~~~~~
    ../common/ns_reads.c: In function '__ns_ldap_host2dn':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:4301:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_WARNING, *errorp, NS_LDAP_INTERNAL, strdup(errstr),
       ^~~~~~~
    ../common/ns_reads.c: In function '__ns_ldap_getServiceAuthMethods':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:4487:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_WARNING, *errorp, NS_CONFIG_SYNTAX,
         ^~~~~~~
    ../common/ns_reads.c: In function '__s_api_convert_automountmapname':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_reads.c:4589:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *errp, NS_CONFIG_SYNTAX,
       ^~~~~~~

    In file included from ../common/ns_mapping.c:30:0:
    ../common/ns_mapping.c: In function '__ns_ldap_getSearchDescriptors':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_mapping.c:688:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_ERR, *errorp, NS_CONFIG_NOTLOADED, strdup(errstr),
       ^~~~~~~
    ../common/ns_mapping.c:766:30: error: comparison between pointer and integer [-Werror]
       while (srv != NULL && *srv != NULL) {
                                  ^~
    In file included from ../common/ns_mapping.c:30:0:
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_mapping.c:776:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_ERR, *errorp, NS_CONFIG_SYNTAX,
         ^~~~~~~

    In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/string_iso.h:50:0,
                     from /code/illumos-gate/proto/root_i386/usr/include/string.h:33,
                     from ../common/ns_connmgmt.c:28:
    ../common/ns_connmgmt.c: In function 'start_thread':
    /code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: passing argument 2 of 'thr_create' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../common/ns_connmgmt.c:2626:23: note: in expansion of macro 'NULL'
      if (thr_create(NULL, NULL, get_server_change,
                           ^~~~
    In file included from ../common/ns_connmgmt.h:36:0,
                     from ../common/ns_connmgmt.c:40:
    /code/illumos-gate/proto/root_i386/usr/include/thread.h:54:12: note: expected 'size_t {aka unsigned int}' but argument is of type 'void *'
     extern int thr_create(void *, size_t, void *(*)(void *), void *, long,
                ^~~~~~~~~~

    In file included from ../common/ns_connect.c:42:0:
    ../common/ns_connect.c: In function '__s_api_requestServer':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_connect.c:356:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *error, NS_CONFIG_CACHEMGR,
        ^~~~~~~
    ../common/ns_connect.c: In function 'process_pwd_mgmt':
    ../common/ns_internal.h:232:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_connect.c:1171:4: note: in expansion of macro 'MKERROR_PWD_MGMT'
        MKERROR_PWD_MGMT(*errorp,
        ^~~~~~~~~~~~~~~~
    ../common/ns_internal.h:232:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_connect.c:1269:6: note: in expansion of macro 'MKERROR_PWD_MGMT'
          MKERROR_PWD_MGMT(*errorp,
          ^~~~~~~~~~~~~~~~
    ../common/ns_internal.h:232:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_connect.c:1277:6: note: in expansion of macro 'MKERROR_PWD_MGMT'
          MKERROR_PWD_MGMT(*errorp,
          ^~~~~~~~~~~~~~~~
    ../common/ns_internal.h:232:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_connect.c:1298:5: note: in expansion of macro 'MKERROR_PWD_MGMT'
         MKERROR_PWD_MGMT(*errorp,
         ^~~~~~~~~~~~~~~~

    In file included from ../common/ns_writes.c:44:0:
    ../common/ns_writes.c: In function 'write_state_machine':
    ../common/ns_internal.h:232:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_writes.c:1068:5: note: in expansion of macro 'MKERROR_PWD_MGMT'
         MKERROR_PWD_MGMT(*errorp, Errno, err,
         ^~~~~~~~~~~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_writes.c:1071:5: note: in expansion of macro 'MKERROR'
         MKERROR(LOG_INFO, *errorp, Errno, err, NULL);
         ^~~~~~~
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_writes.c:1088:4: note: in expansion of macro 'MKERROR'
        MKERROR(LOG_WARNING, *errorp, return_rc, err, NULL);
        ^~~~~~~
    ../common/ns_writes.c: In function 'modify_ethers_bootp':
    ../common/ns_writes.c:2857:36: error: comparison between pointer and integer [-Werror]
      if (strcasecmp(service, "ethers") == NULL) {
                                        ^~
    In file included from ../common/ns_writes.c:44:0:
    ../common/ns_writes.c: In function 'send_to_cachemgr':
    ../common/ns_internal.h:218:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (retErr); \
              ^
    ../common/ns_writes.c:4135:3: note: in expansion of macro 'MKERROR'
       MKERROR(LOG_WARNING, *errorp, NS_CONFIG_CACHEMGR,
       ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Toomas Soome 4 months ago

  • Status changed from Feedback to In Progress
#2

Updated by Electric Monk 3 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 51b02b292e47be2588e43efa7cff6e9fc931fba0

commit  51b02b292e47be2588e43efa7cff6e9fc931fba0
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-03T07:29:11.000Z

    11167 libsldap: NULL pointer errors
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF