Project

General

Profile

Actions
Copy link

Feature #11176

closed

usba kernel module should be CERRWARN and smatch clean

Added by Robert Mustacchi over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

As we're doing other work in the usba kernel module, we should use this opportunity to go ahead and clean up the gagged compiler and smatch warnings.

As this touched a number of different aspects of the USB stack, I did the following testing on this:

  • Testing on Skylake xhci hardware and VMware virtualized USB controllers
  • Used nested hubs and verified that we detected devices on the nested hubs and could get information about them
  • Tested basic bulk operations worked
  • Verified basic interrupt USB transfers work via USB keyboards
  • Verified that I could use USB Audio Isochronous transfers
  • Used the yubikey tools that use libusb to make sure that ugen still work
Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed

git commit 0d2006e4703eda0f88de2e571bf9fb317552faa2

commit  0d2006e4703eda0f88de2e571bf9fb317552faa2
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-06-14T22:23:14.000Z

    11177 usba should read the device binary object store
    11178 USB topology could know about supported, minimum speeds
    11179 usba parsing code should take const data pointers
    11176 usba kernel module should be CERRWARN and smatch clean
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Approved by: Gordon Ross <gordon.ross@nexenta.com>

Actions
Copy link

Also available in: Atom PDF