Project

General

Profile

Bug #11206

mdb output autowrapping still subtly wrong

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
mdb - modular debugger
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

mdb's autowrapping is (still) subtly wrong. For example, here is a case that doesn't autowrap, but should:

% mdb -e '-1,4=J'
                ffffffffffffffff ffffffffffffffff ffffffffffffffff ffffffffffffffff

And here's a case that does autowrap but shouldn't:

% mdb -e '::typedef -c lp32 ; 0::printf "%-80d%d" int . .' | wc -l
       2

This, by contrast, has expected results:

% mdb -e '::typedef -c lp32 ; 0::printf "%-79d %d" int . .' | wc -l
       1

We need to (1) turn autowrapping on manually whenever printing a format character and (2) only autowrap on mdb_printf()-induced whitespace if autowrapping is on.

History

#1

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed

git commit c8a3ee0e3658c32402e6bd505596d4fa45bfe17c

commit  c8a3ee0e3658c32402e6bd505596d4fa45bfe17c
Author: Bryan Cantrill <bryan@joyent.com>
Date:   2019-06-25T00:12:14.000Z

    11208 add mdb format character for jazzed-up binary output
    11206 mdb output autowrapping still subtly wrong
    11207 many 64-bit mdb format characters have insufficient width
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF