Project

General

Profile

Bug #11248

Panic in smb_ofile_free after 11016

Added by Gordon Ross over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Sorry about this, but a little bit of the changes for
#11031 SMB3 persistent handles
ended up in my commit for #11016
(an ASSERT that panics)

History

#1

Updated by Gordon Ross over 1 year ago

  • Status changed from New to In Progress

Fix is fairly simple. Remove this assert from smb_ofile_free

http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/fs/smbsrv/smb_ofile.c#1382

    /* Make sure it's not in the persistid hash. */
    1382    ASSERT(of->f_persistid == 0);

That check is only correct after the changes for #11031

#2

Updated by Gordon Ross over 1 year ago

  • Status changed from In Progress to Pending RTI
#3

Updated by Electric Monk over 1 year ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 37b221f0ca7d390480c67caa3db64384a2b81406

commit  37b221f0ca7d390480c67caa3db64384a2b81406
Author: Gordon Ross <gwr@nexenta.com>
Date:   2019-06-17T15:12:25.000Z

    11248 Panic in smb_ofile_free after 11016
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF