Project

General

Profile

Bug #11262

Memory leak in SMB client

Added by Gordon Ross 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Looking at the output from ::findleaks -dvf

[...]
ffffd0661dc28088 ffffd06620c0e640  1219a7a640b39fc ffffd06605c0a0e0
                 ffffd06517489008 ffffd0638f54e340 ffffd0645537cc98
                 kmem_cache_alloc_debug+0x2e8
                 kmem_cache_alloc+0xd4
                 allocb_wait+0x64
                 allocb_cred_wait+0x3a
                 mb_init+0x34
                 smb_cpdatain+0x43
                 smb_usr_xnp+0x110
                 smb_usr_ioctl+0x1a1
                 nsmb_ioctl+0xaa
                 cdev_ioctl+0x39
                 spec_ioctl+0x60
                 fop_ioctl+0x55
                 ioctl+0x9b
                 dtrace_systrace_syscall32+0xe4
<pre>


Files

History

#1

Updated by Gordon Ross 4 months ago

This is a fairly slow leak, affecting only named-pipe operations, which is why it went unnoticed for a while.

Fix attached

#2

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit e3a966fe577766e1cf319609f3e0a5981c5b3e7d

commit  e3a966fe577766e1cf319609f3e0a5981c5b3e7d
Author: Gordon Ross <gwr@nexenta.com>
Date:   2019-06-20T00:45:49.000Z

    11262 Memory leak in SMB client
    Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF