Project

General

Profile

Feature #11273

Want Intel PCH temperature sensor

Added by Robert Mustacchi 27 days ago. Updated 22 days ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

We'd like to add support for the temperature sensor that exists on various Intel chipsets, commonly called the platform controller hub in Intel parlance. Specifically this adds support for the various revisions that were introduced with Haswell. The sensor has a different format before that and currently isn't supported by the driver. This currently covers:

  • Haswell Client / Server
  • Broadwell Client / Server
  • Skylake, Kaby Lake, Coffee Lake Client
  • Skylake, Cascade Lake Server

I tested this by loading this on the following platforms which have the
following chipsets:

  • Intel Series 8 Chipset (8086,8c24) (Haswell client part)
  • Intel C620 Series (8086,a1b1) (Skylake/Cascade Lake Server)
  • Intel 7th/8th Generation Processor Family U/Y Platforms / Sunrise Point (8086,9d31) (Kaby Lake NUC)
  • Intel 300 Series Chipset Cannon Lake PCH Thermal Controller (8086,a379) (Cannnon Lake Desktop)

In each case I verified that the driver attached and we had output from
fmtopo and the temperature looked reasonable. When available, I double
checked that the temperature was close to that from another source like
IPMI.

I also checked that the following systems did not have a chipset node in
topo and the rest of the topo correctly enumerated:

  • AMD Epyc 2s server platform
  • Intel Ivy Bridge 6-series client system

Here's example output from a system of what now enumerates:

# /usr/lib/fm/fmd/fmtopo -V *chipset*
TIME                UUID
Jun 03 18:07:42 bf5aba3e-dba5-c56b-9a5a-d31941db7f46

hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0
    FRU               fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0
  group: authority                      version: 1   stability: Private/Private
    product-id        string    X10SLM+-LN4F
    chassis-id        string    0123456789
    server-id         string    haswell

hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    product-id        string    X10SLM+-LN4F
    chassis-id        string    0123456789
    server-id         string    haswell
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    43.500000

History

#1

Updated by Electric Monk 22 days ago

  • Status changed from New to Closed

git commit dc90e12310982077796c5117ebfe92ee04b370a3

commit  dc90e12310982077796c5117ebfe92ee04b370a3
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-06-27T01:29:11.000Z

    11273 Want Intel PCH temperature sensor
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Paul Winder <Paul.Winder@wdc.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF