Project

General

Profile

Feature #11275

gettimeofday should use comm page

Added by Robert Mustacchi 10 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

With the introduction of the comm page in #7805 improved clock_gettime(), it did not improve the gettimeofday() system call which is often pounded on by folks. This implements gettimeofday in terms of the comm page to bring down the cost of getting that substantially.


Related issues

Related to illumos gate - Feature #7805: want faster clock_gettimeClosed2017-01-25

Actions
Related to illumos gate - Feature #12345: comm page should fallback to syscall after excessive migrationClosed

Actions

History

#1

Updated by Patrick Mooney about 1 month ago

This is the upstreamed version of OS-6014 from SmartOS, where it has been in production for years.

As follow-up testing on the upstreamed wad, I confirmed that gettimeofday() output matched that from clock_gettime().

#2

Updated by Joshua M. Clulow about 1 month ago

  • Description updated (diff)
#3

Updated by Joshua M. Clulow about 1 month ago

#4

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed

git commit 2c2b5e89f6b9617f543c1b581759525f4730690e

commit  2c2b5e89f6b9617f543c1b581759525f4730690e
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-02-27T20:05:30.000Z

    11275 gettimeofday should use comm page
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Andrew Stormont <astormont@racktopsystems.com>
    Reviewed by: Garrett D'Amore <gdamore@racktopsystems.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

#5

Updated by Patrick Mooney about 1 month ago

  • Related to Feature #12345: comm page should fallback to syscall after excessive migration added

Also available in: Atom PDF