Project

General

Profile

Bug #11279

AMD F17 core topology is per process node

Added by Robert Mustacchi 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

When introducing the new AMD core topology I made a mistake. To determine the package core ID, I used the extended leaf 0x15 ebx register. This has the core id in it. However, this is the core ID within the package. This means that the way we've calculated the package core isn't actually unique to the package (the whole physical chip), but rather unique to the process node, of which there are multiple inside. This can cause several problems. The solution is to calculate this like we do on Intel by leveraging the APIC ID relationship.

History

#1

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed

git commit 15a5383b049109e4ce37a4a457a933812f189141

commit  15a5383b049109e4ce37a4a457a933812f189141
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-07-10T15:49:19.000Z

    11279 AMD F17 core topology is per process node
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF