Project

General

Profile

Actions

Bug #11303

closed

cron: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with NULL pointer:

    crontab.c: In function 'copycron':
    crontab.c:449:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *x = NULL;
            ^
    crontab.c:465:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *x = NULL;
            ^
    crontab.c:481:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *x = NULL;
            ^

    cron.c: In function 'readcron':
    cron.c:1170:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *tmp = NULL;
              ^
    cron.c:1188:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *tmp = NULL;
              ^
    cron.c:1202:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *tmp = NULL;
              ^
    cron.c: In function 'process_msg':
    cron.c:2842:18: error: comparison between pointer and integer [-Werror]
      if (pmsg->etype == NULL)
                      ^~

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 19803d096124c0f1ca62906eb328234556bfad35

commit  19803d096124c0f1ca62906eb328234556bfad35
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-09T05:45:05.000Z

    11303 cron: NULL pointer errors
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF