Project

General

Profile

Actions

Bug #11340

closed

gettext: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with NULL pointer:

    gettext.c: In function 'expand_metas':
    gettext.c:56:26: error: comparison between pointer and integer [-Werror]
      for (cp = out = in; *in != NULL; out++, in++) {
                              ^~
    gettext.c:84:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      *out = NULL;
           ^
    gettext.c: In function 'main':
    gettext.c:231:16: error: comparison between pointer and integer [-Werror]
       exit(*domain == NULL);
                    ^~
    gettext.c:254:39: error: comparison between pointer and integer [-Werror]
      return ((domain == NULL) || (*domain == NULL));
                                           ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2e837a72011f54762249b6612c2a64f171efcd43

commit  2e837a72011f54762249b6612c2a64f171efcd43
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-12T05:45:29.000Z

    11340 gettext: NULL pointer errors
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF