Project

General

Profile

Feature #11372

Want PCIe dcmds and walkers

Added by Robert Mustacchi 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

It would be useful to have an mdb walker that knew how to iterate over the various pcie_bus_t structures in the kernel. This will make it easier to inspect and debug state in the system.

To test this, I did the following:

  • Ran ::walk devinfo | ::devinfo -d.
  • Ran ::prtconf -d igb | ::devinfo -d | ::print igb_t and verified that the structures were correct.
  • Ran ::walk pcie_bus and verified that I saw most of the structures that I expected.
  • Ran *pcieb_state::walk softstate | ::print pcieb_devstate_t pcieb_dip | ::devinfo -b pcie | ::print pcie_bus_t bus_sup_speed and verified that the data was correct and that we had reasonable pcie_bus_t structures.
  • Verified that ::devinfo -b and ::devinfo -d didn't work with other arguments.
  • Verified that combination of ::devinfo -q and ::devinfo -s worked as they did previously.
  • Verified that passing an address to the pcie_bus walker failed (it only supports global walks)

History

#1

Updated by Electric Monk 8 months ago

  • Status changed from New to Closed

git commit e386d4dde2e66dfdb5d0ac143d970d0a77af2786

commit  e386d4dde2e66dfdb5d0ac143d970d0a77af2786
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-08-19T17:40:33.000Z

    11372 Want PCIe dcmds and walkers
    Reviewed by: Jon Anderson <jon.anderson@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Paul Winder <Paul.Winder@wdc.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF