Project

General

Profile

Feature #11373

pcieb should enable link bandwidth notifications

Added by Robert Mustacchi 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

We should go through and enable the link bandwidth notifications for devices that exist in the system so that way when a link has been renegotiated, we can go through and update our internal state about that is and generate a system event so that way user land may optionally dig in and verify that this change made sense.

I tested this in a few different ways:

1. By using the new /usr/lib/pci/pcieb command to reset the link on bridges.
2. By pulling NVMe U.2 devices from slots and inserting them again.

In both cases I verified that sysevents were generated that referred to the correct sub-tree and then went through and verified that if the link status had changed, that we now had up to date information about the value. I also used the pcieb command to go through and test limiting the link speed and verifying that it fired.

History

#1

Updated by Electric Monk about 2 months ago

  • Status changed from New to Closed

git commit b3d69c058376d802cdebbced341adcb3253b113c

commit  b3d69c058376d802cdebbced341adcb3253b113c
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-08-19T17:40:33.000Z

    11376 PCIe speeds and feeds should be exposed to userland
    11373 pcieb should enable link bandwidth notifications
    11374 Clean up pcieb CERRWARN and smatch
    11375 Clean up pcie module -Wno-uninitialized and -Wno-parentheses
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Paul Winder <Paul.Winder@wdc.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

#2

Updated by Electric Monk about 2 months ago

git commit e7a617a7b674323dacb8a0d3ac64c275c7a72b0c

commit  e7a617a7b674323dacb8a0d3ac64c275c7a72b0c
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-08-19T22:27:02.000Z

    11373 pcieb should enable link bandwidth notifications (add missing file)
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF