Project

General

Profile

Bug #11382

ldap: NULL pointer errors

Added by Toomas Soome 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Build errors with NULL pointer:

    ../ns_ldap/ldapaddent.c: In function 'encode_network':
    ../ns_ldap/ldapaddent.c:147:19: error: comparison between pointer and integer [-Werror]
      while ((c = *cp) != NULL) {
                       ^~

    ../ns_ldap/ldaplist.c: In function 'main':
    ../ns_ldap/ldaplist.c:491:53: error: comparison between pointer and integer [-Werror]
      if (database && (strcasecmp(database, "publickey") == NULL)) {
                                                         ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 3 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit c59d9dff034f6cf5330aceb38bb1757d01e3904e

commit  c59d9dff034f6cf5330aceb38bb1757d01e3904e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-07-18T06:02:19.000Z

    11382 ldap: NULL pointer errors
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF