Bug #11394
closed
iconv_modules build could be much more parallel
100%
Description
usr/src/lib/iconv_modules builds very serially for no real reason, at least in my builds it often takes longer than all the rest of usr/src/lib together, and is delaying the move into building usr/src/cmd
Trivial parallelism improves this radically (almost 2x), and buys a minute or two.
Updated by Electric Monk over 4 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 270832fa1e63c01a4a8ecb6dc23eb148a4d54831
commit 270832fa1e63c01a4a8ecb6dc23eb148a4d54831
Author: Richard Lowe <richlowe@richlowe.net>
Date: 2019-07-16T21:54:57.000Z
11394 iconv_modules build could be much more parallel
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Updated by Rich Lowe over 4 years ago
There's a narrow race Mike Gerdts hit and debugged in this, it runs thuswise:
utf-8/Makefile.com (and probably ja/Makefile.com) define an install rule that rather than being dependency based, loops over files to do the installation.
This rule causes the build of what are conceptually common files, and because it's in Makefile.com causes them to be built per platform unnecessarily. This causes them to install from both platform directories, now possibly simultaneously.
Because this loop does rm/install/chmod, it leaves a window where chmod may have the file removed underneath it by the install in the other directory.
We need to re-write these targets properly, and to have them not run unnecessarily in each platform
Updated by Electric Monk over 4 years ago
git commit 01d6bbace7ed9d92acc6fd5dfcb2b18c2dd18e85
commit 01d6bbace7ed9d92acc6fd5dfcb2b18c2dd18e85
Author: Robert Mustacchi <rm@joyent.com>
Date: 2019-07-17T22:09:37.000Z
backout: 11394 iconv_modules build could be much more parallel (breaks build)
Updated by Rich Lowe over 4 years ago
Oh, and of course you can't rewrite these rules properly, because make(1S) provides no way to escape a '%'. The best you can do is trust it to only match itself
Updated by Electric Monk over 4 years ago
git commit dfe6d73f5cf5922a7dfdafeac8df9775afb2d992
commit dfe6d73f5cf5922a7dfdafeac8df9775afb2d992
Author: Richard Lowe <richlowe@richlowe.net>
Date: 2019-08-22T23:22:43.000Z
11394 iconv_modules build could be much more parallel
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Robert Mustacchi <rm@joyent.com>