Project

General

Profile

Actions
Copy link

Bug #11434

closed

stmsboot: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with NULL pointer:

    stmsboot_util.c: In function 'parse_args':
    stmsboot_util.c:414:36: error: comparison between pointer and integer [-Werror]
        if ((strncmp(drvlimit, "fp", 2) == NULL) &&
                                        ^~
    stmsboot_util.c:415:37: error: comparison between pointer and integer [-Werror]
            (strncmp(drvlimit, "mpt", 3) == NULL) &&
                                         ^~
    stmsboot_util.c:416:41: error: comparison between pointer and integer [-Werror]
            (strncmp(drvlimit, "mpt_sas", 7) == NULL) &&
                                             ^~
    stmsboot_util.c:417:38: error: comparison between pointer and integer [-Werror]
            (strncmp(drvlimit, "pmcs", 4) == NULL)) {
                                          ^~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6cb11604688f3d2bf2fb6d030c1f2bb3673a10d2

commit  6cb11604688f3d2bf2fb6d030c1f2bb3673a10d2
Author: Toomas Soome <tsoome@me.com>
Date:   2019-08-06T15:34:52.000Z

    11434 stmsboot: NULL pointer errors
    11510 stmsboot: stmsboot_util -D option validation is broken
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF