Project

General

Profile

Actions

Bug #11453

closed

zpool: NULL pointer errors

Added by Toomas Soome almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    zpool_vdev.c: In function 'check_disk':
    zpool_vdev.c:196:31: error: comparison between pointer and integer [-Werror]
          &err)) == NULL || *drive == NULL) {
                                   ^~
    zpool_vdev.c:216:13: error: comparison between pointer and integer [-Werror]
      if (*media == NULL) {
                 ^~
    zpool_vdev.c:238:23: error: comparison between pointer and integer [-Werror]
      for (i = 0; slice[i] != NULL; i++) {
                           ^~
    zpool_vdev.c: In function 'check_device':
    zpool_vdev.c:267:62: error: comparison between pointer and integer [-Werror]
      if ((desc = dm_get_descriptor_by_name(DM_ALIAS, dev, &err)) != NULL) {
                                                                  ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk almost 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8a5bcf73f651354eb7fa4fcdb486cf455b09303c

commit  8a5bcf73f651354eb7fa4fcdb486cf455b09303c
Author: Toomas Soome <tsoome@me.com>
Date:   2019-08-05T16:30:01.000Z

    11453 zpool: NULL pointer errors
    Reviewed by: Jason Lippert <jason@glasspelican.ca>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF