Project

General

Profile

Feature #11491

Want DLS bypass for VLAN traffic

Added by Robert Mustacchi over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
networking
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

If a MAC client has only 1 VID, as is the case for tagged VNICs, then we can take advantage of DLS bypass for VLAN traffic.

The current logic sets the s_ring_rx_func of a tagged VNIC to mac_rx_deliver(). This function, upon seeing that there is only 1 VID, strips the VLAN header and delivers it to the client receive function: i_dls_link_rx(). This function then calls ip_input().

Since there is only 1 VID there is no reason to go through i_dls_link_rx() when it's just going to deliver it to ip_input() anyways.

If we do this there should be a clear performance benefit as it will probably make the code slightly more complicated.


Related issues

Related to illumos gate - Bug #11490: SRS ring polling disabled for VLANsClosedRyan Zezeski

Actions
#1

Updated by Robert Mustacchi over 1 year ago

  • Related to Bug #11490: SRS ring polling disabled for VLANs added
#2

Updated by Electric Monk about 1 year ago

  • Status changed from New to Closed

git commit 84de666edc7f7d835057ae4807a387447c086bcf

commit  84de666edc7f7d835057ae4807a387447c086bcf
Author: Ryan Zezeski <ryan@zinascii.com>
Date:   2020-03-02T07:24:09.000Z

    11490 SRS ring polling disabled for VLANs
    11491 Want DLS bypass for VLAN traffic
    11492 add VLVF bypass to ixgbe core
    2869 duplicate packets with vnics over aggrs
    11489 DLS stat delete and aggr kstat can deadlock
    Portions contributed by: Theo Schlossnagle <jesus@omniti.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Paul Winder <paul@winders.demon.co.uk>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF