Project

General

Profile

Actions

Bug #1150

closed

libcmdutils has superfluous #define

Added by Jason King almost 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Low
Category:
lib - userland libraries
Start date:
2011-06-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

usr/src/lib/libcmdutils.h has the following define:

#define ISREG(A) (((A).st_mode & S_IFMT) == S_IFREG)

This is largely unneeded and S_ISREG is probably a better choice.

Actions #1

Updated by David Höppner about 7 years ago

  • Status changed from New to In Progress
  • Assignee set to David Höppner
  • % Done changed from 0 to 90
Actions #2

Updated by Electric Monk about 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2cf749481ab62b6f2e7a25e42c1870d102ce112c

commit  2cf749481ab62b6f2e7a25e42c1870d102ce112c
Author: David Höppner <0xffea@gmail.com>
Date:   2015-03-09T14:13:14.000Z

    1150 libcmdutils has superfluous #define
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions

Also available in: Atom PDF