Project

General

Profile

Actions
Copy link

Bug #11529

closed

Use -Wno-maybe-initialized

Added by John Levon almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With a giant sed and some small code changes, we can replace most -Wno-uninitialized
with -Wno-maybe-uninitialized across the whole source base, when using GCC7 and up.

Actions
Copy link
 #1

Updated by John Levon almost 3 years ago

Changes that aren't just from the sedall:

 - usr/src/cmd/zlogin/ needed a small change (no bug)
 - usr/src/lib/gss_mechs/mech_krb5/krb5/krb/gic_pwd.c was broken
 - usr/src/lib/libc/inc/thr_inlines.h - GCC complains as we state that '__value' in
   set_lock_byte() is read-write. But in fact we always write first. Rather than
   try to change the +d to d, we'll just set to zero
 - __class_quadruple hack
 - Makefile.uts has the new flag
 - usr/src/uts/common/vm/vm_pagelist.c and related, harmless fix
 - kept -Wno-uninitialized for ucblib
Actions
Copy link
 #2

Updated by Electric Monk almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d3b5f56344d8bfcdd6cfb82446af0e5e55ad9ebe

commit  d3b5f56344d8bfcdd6cfb82446af0e5e55ad9ebe
Author: John Levon <john.levon@joyent.com>
Date:   2019-08-16T08:57:38.000Z

    11528 Makefile.noget can get gone
    11529 Use -Wno-maybe-initialized
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF