Project

General

Profile

Actions
Copy link

Bug #11531

closed

tools/make should set NATIVE_CCFLAGS

Added by Toomas Soome about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We are building tools/make to run it as native binary, but c++ code is not built with NATIVE_CCFLAGS (inconsistent with C code).

Makefile.master does not really have NATIVE_CCFLAGS, so we need to create one. And 32-bit CCFLAGS do not set XARCH flag (-m32) which is bad when compiler will produce 64-bit code by default.

Actions
Copy link
 #1

Updated by Electric Monk almost 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a99cb9618990662acbd3bab1b4a5b05a6ca62556

commit  a99cb9618990662acbd3bab1b4a5b05a6ca62556
Author: Toomas Soome <tsoome@me.com>
Date:   2019-08-21T05:49:13.000Z

    11531 tools/make should set NATIVE_CCFLAGS
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF