Project

General

Profile

Actions
Copy link

Bug #11549

closed

loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Got errors from smatch:

/code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../efi_console.c:372 efi_cons_cursor() error: uninitialized symbol 'row'.
/code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../efi_console.c:373 efi_cons_cursor() error: uninitialized symbol 'col'.

Lets just set them 0.

Testing done: build/install/boot cycle.

Actions
Copy link
 #1

Updated by Toomas Soome about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c6dd35daf6754ceadffe27f721e78fec1f894036

commit  c6dd35daf6754ceadffe27f721e78fec1f894036
Author: Toomas Soome <tsoome@me.com>
Date:   2019-08-14T19:22:49.000Z

    11549 loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF