Project

General

Profile

Actions

Bug #11565

closed

loader: this statement may fall through

Added by Toomas Soome almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with warnings enabled:

    /code/illumos-gate/usr/src/boot/lib/libstand/printf.c: In function 'kvprintf':
    /code/illumos-gate/usr/src/boot/lib/libstand/printf.c:319:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (!dot) {
           ^
    /code/illumos-gate/usr/src/boot/lib/libstand/printf.c:323:3: note: here
       case '1': case '2': case '3': case '4':
       ^~~~
    /code/illumos-gate/usr/src/boot/lib/libstand/printf.c:482:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
        upper = 1;
        ~~~~~~^~~
    /code/illumos-gate/usr/src/boot/lib/libstand/printf.c:483:3: note: here
       case 'x':
       ^~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Toomas Soome almost 3 years ago

Tested by build/install/boot cycle.

Actions #2

Updated by Electric Monk almost 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 4c528395822a1beb30134bcd9f7f8b6813db6e5d

commit  4c528395822a1beb30134bcd9f7f8b6813db6e5d
Author: Toomas Soome <tsoome@me.com>
Date:   2019-08-19T15:27:00.000Z

    11565 loader: this statement may fall through
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Robert Mustacchi <robert.mustacchi@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF