Project

General

Profile

Actions
Copy link

Bug #11646

closed

fbt entry probes incorrectly placed due to -fshrink-wrap

Added by John Levon about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

http://smartos.org/bugview/OS-7973

We need to use -fno-shrink-wrap to prevent GCC from moving branches to before the function prologue, which means that fbt tracing will miss function entries, as it looks for a pushq %rbp.

Actions
Copy link
 #1

Updated by John Levon about 4 years ago

  • Subject changed from OS-7973 fbt entry probes incorrectly placed due to -fshrink-wrap to fbt entry probes incorrectly placed due to -fshrink-wrap
Actions
Copy link
 #2

Updated by Electric Monk about 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d58ceae2ed78dc65ab682a0281ce523d6c4116fe

commit  d58ceae2ed78dc65ab682a0281ce523d6c4116fe
Author: John Levon <john.levon@joyent.com>
Date:   2019-09-04T13:54:48.000Z

    11646 fbt entry probes incorrectly placed due to -fshrink-wrap
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF