Bug #11647
6026 regressed after 5980
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
Description
As seen in the below disassembly, smb_inet_ntop calls the "unfixed" version:
smb_inet_ntop: pushq %rbp smb_inet_ntop+1: movq %rdi,%rax smb_inet_ntop+4: movl %edx,%ecx smb_inet_ntop+6: movq %rsp,%rbp smb_inet_ntop+9: pushq %rdi smb_inet_ntop+0xa: pushq %rsi smb_inet_ntop+0xb: pushq %rdx smb_inet_ntop+0xc: movq %rsi,%rdx smb_inet_ntop+0xf: movq %rax,%rsi smb_inet_ntop+0x12: subq $0x8,%rsp smb_inet_ntop+0x16: movl 0x10(%rdi),%edi smb_inet_ntop+0x19: call +0x3acbbe2 <inet_ntop> smb_inet_ntop+0x1e: leave smb_inet_ntop+0x1f: ret
Related issues
Updated by Yuri Pankov over 1 year ago
- Related to Bug #6026: Zero-padded IP address strings returned by SMB added
Updated by Yuri Pankov over 1 year ago
- Related to Feature #5980: in-kernel inet_ntop should format IPv4 addresses like userland one added
Updated by Yuri Pankov over 1 year ago
To test this, I used mdb -ke smb_inet_ntop::dis to check that correct symbol is being used:
# mdb -ke smb_inet_ntop::dis smb_inet_ntop: pushq %rbp smb_inet_ntop+1: movl %edx,%ecx smb_inet_ntop+3: movq %rsp,%rbp smb_inet_ntop+6: subq $0x20,%rsp smb_inet_ntop+0xa: movq %rdx,-0x18(%rbp) smb_inet_ntop+0xe: movq %rsi,-0x10(%rbp) smb_inet_ntop+0x12: movq %rsi,%rdx smb_inet_ntop+0x15: movq %rdi,-0x8(%rbp) smb_inet_ntop+0x19: movl 0x10(%rdi),%eax smb_inet_ntop+0x1c: movq %rdi,%rsi smb_inet_ntop+0x1f: movl %eax,%edi smb_inet_ntop+0x21: call +0x3aaaaba <_inet_ntop> smb_inet_ntop+0x26: leave smb_inet_ntop+0x27: ret
Updated by Electric Monk over 1 year ago
- Status changed from In Progress to Closed
- % Done changed from 50 to 100
git commit 2b1ff28bbd88f04a83e6ca2d284eb7be0959c43c
commit 2b1ff28bbd88f04a83e6ca2d284eb7be0959c43c
Author: Gordon Ross <gwr@nexenta.com>
Date: 2019-09-07T16:22:01.000Z
11647 6026 regressed after 5980
Reviewed by: Evan Layton <evan.layton@nexenta.com>
Reviewed by: Matt Barden <matt.barden@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Reviewed by: Gergő Doma <domag02@gmail.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>