Project

General

Profile

Bug #11682

zpool iostat and status improvements

Added by Jerry Jelinek about 1 year ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Port the following from ZoL:
193a37cb243 Add -lhHpw options to "zpool iostat" for avg latency, histograms,
7e945072d18 Add request size histograms (-r) to zpool iostat, minor man page fix
410921241d0 Add -y option to `zpool iostat`
8fccfa8e17d zpool iostat should print headers when terminal fills
ad796b8a3b2 Add zpool status -s (slow I/Os) and -p (parseable)
f8bb2a7e0c8 Clarify zpool iostat statistics reporting
f23b0242b68 Fix '-T u|d' descriptions in zpool(8)
57dc41de96c Fix zpool iostat -w header names
b954e36e512 Zpool iostat: remove latency/queue scaling
eb201f50ac0 Add back iostat -y or -w descriptions
674b89342e4 Fix segfault in zpool iostat when adding VDEVs
2df9ad1c075 Fix column alignment with long zpool names
29eb4942856 Dashes for zero latency values in zpool iostat -p
5034557bdd5 Fix 'zpool iostat -v' cache and log output
272be6834c3 Fix zpool iostat bandwidth/ops calculation


Related issues

Related to illumos gate - Bug #13209: 11682 lost spa_bootsize from expandsize calculationClosed

Actions

History

#1

Updated by Jerry Jelinek 10 months ago

  • % Done changed from 0 to 90
#2

Updated by Jerry Jelinek 8 months ago

For testing, I have run the zfs test suite on both DEBUG and non-DEBUG builds. This includes the new tests which all pass. In addition I have done manual testing of all of the new iostat and status subcommand options to visually verify that the output is formatted properly and looks reasonable.

#3

Updated by Electric Monk 8 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit dd50e0cc4cbe1474096300fe52e9855769c0d478

commit  dd50e0cc4cbe1474096300fe52e9855769c0d478
Author: Tony Hutter <hutter2@llnl.gov>
Date:   2020-02-13T17:45:47.000Z

    11682 zpool iostat and status improvements
    Portions contributed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Portions contributed by: Hajo Möller <dasjoe@gmail.com>
    Portions contributed by: Damian Wojslaw <damian@wojslaw.pl>
    Portions contributed by: kpande <github@tripleback.net>
    Portions contributed by: Anatoly Borodin <anatoly.borodin@gmail.com>
    Portions contributed by: Gregor Kopka <mailfrom-github@kopka.net>
    Portions contributed by: George Melikov <mail@gmelikov.ru>
    Portions contributed by: George G <gg7@users.noreply.github.com>
    Portions contributed by: DeHackEd <DeHackEd@users.noreply.github.com>
    Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
    Reviewed by: Tim Chase <tim@chase2k.com>
    Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
    Reviewed by: Giuseppe Di Natale <guss80@gmail.com>
    Reviewed by: George Melikov <mail@gmelikov.ru>
    Reviewed by: Tony Hutter <hutter2@llnl.gov>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Alek Pinchuk <apinchuk@datto.com>
    Reviewed by: Allan Jude <allanjude@freebsd.org>
    Reviewed by: Olaf Faaland <faaland1@llnl.gov>
    Reviewed by: loli10K <ezomori.nozomu@gmail.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

#4

Updated by Jorge Schrauwen 8 months ago

Did a commit get dropped somewhere?

[root@boron ~]# zpool iostat -r

zones         sync_read    sync_write    async_read    async_write      scrub         trim
req_size      ind    agg    ind    agg    ind    agg    ind    agg    ind    agg    ind    agg
----------  -----  -----  -----  -----  -----  -----  -----  -----  -----  -----  -----  -----
512             0      0      0      0      0      0      0      0      0      0      0      0
1K              0      0      0      0      0      0      0      0      0      0      0      0
2K              0      0      0      0      0      0      0      0      0      0      0      0
4K           311K      0  71.2K      0  10.3K      0  1.80M      0    129      0      0      0
8K           550K     15    440      0  23.0K    853   423K   288K     19     12      0      0
16K            83     41    208      0      1  3.29K   167K   160K      6      8      0      0
32K         2.23K     19  2.30K      0    373  3.42K   142K  71.7K      0     15      0      0
64K           156      8  6.78K      0      0  1.64K  1.34K  51.1K      0      5      0      0
128K           38      2  14.5K     49     11    237  13.4K  37.4K     18      1      0      0
256K            0      0      0    202      0      3      0  22.1K      0      0      0      0
512K            0      0      0    158      0      2      0  6.90K      0      0      0      0
1M              0      0      0    113      0      0      0     52      0      0      0      0
2M              0      0      0      0      0      0      0      0      0      0      0      0
4M              0      0      0      0      0      0      0      0      0      0      0      0
8M              0      0      0      0      0      0      0      0      0      0      0      0
16M             0      0      0      0      0      0      0      0      0      0      0      0
----------------------------------------------------------------------------------------------
[root@boron ~]# man zpool^C
[root@boron ~]# zpool iostat -x
invalid option 'x'
usage:
        iostat [[-lq]|[-rw]] [-T d | u] [-ghHLpPvy]
            [pool] ... [[-n] interval [count]]

The short usage doesn't mention any of the new flags.

#5

Updated by Jorge Schrauwen 8 months ago

There are also some other cosmetic issues...

[root@boron ~]# zpool iostat mirror
                             capacity     operations     bandwidth
vdev                       alloc   free   read  write   read  write
-------------------------  -----  -----  -----  -----  -----  -----
mirror                      107G   369G     16     60   117K  1.03M
-------------------------  -----  -----  -----  -----  -----  -----[root@boron ~]#
#6

Updated by Jerry Jelinek 8 months ago

For the first comment

Did a commit get dropped somewhere?
...
The short usage doesn't mention any of the new flags.

I don't think a commit was dropped. It appears all of the new flags are there in the usage message. Which flag(s) do you think are missing?

For the second comment

There are also some other cosmetic issues...

Please open a new bug for that. It looks like I missed a newline there during the port.

#7

Updated by Toomas Soome 14 days ago

  • Related to Bug #13209: 11682 lost spa_bootsize from expandsize calculation added

Also available in: Atom PDF